minor change: code cleanup #15447
minor change: code cleanup #15447
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors a loop over the fieldHash array in the flush method from an indexed for-loop to a for-each loop, making the code more concise and idiomatic.
Key changes:
- Replaced indexed for-loop with for-each loop for iterating over
fieldHasharray
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Map<String, TermsHashPerField> fieldsToFlush = new HashMap<>(); | ||
| for (int i = 0; i < fieldHash.length; i++) { | ||
| PerField perField = fieldHash[i]; | ||
| for (PerField perField : fieldHash) { |
There was a problem hiding this comment.
While this refactoring is valid, there are other identical loop patterns over fieldHash in the same file (e.g., in writePoints() at line 371 and writeDocValues() at line 409) that still use the indexed for-loop style. For consistency, consider refactoring those loops to use for-each as well, or keep all of them in the same style.
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution! |
1 participant
A minor code cleanup
refactored the loop over
fieldHashin theflushmethod to use a for-each loop